[header_rewrite] Fix set-body #12560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. set-body with an empty string argument causes heap corruption in The cause is incorrect handling of zero-length strings in MIOBuffer::append_xmalloced. 2. set-body with variable expansion fails to expand the variable. The cause is a typo in the OperatorSetBody::exec() method.
bneradt
previously requested changes
Oct 14, 2025
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. Just a few minor observations.
tests/gold_tests/pluginTest/header_rewrite/header_rewrite_set_body.test.py
Show resolved
Hide resolved
Contributor
Author
|
[approve ci autest 0] |
jasmine-nahrain
approved these changes
Oct 21, 2025
moonchen
dismissed
bneradt’s stale review
The requested changes have been applied.
cmcfarlen
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autest for these bugs.